Skip to content

fix(issue-168): Unify log directory and load_run as single source of truth - #182

Merged
TATP-233 merged 1 commit into
mainfrom
fix/issue-168-unify-log-dir
Apr 9, 2026
Merged

TATP-233 merged 1 commit into
mainfrom
fix/issue-168-unify-log-dir

Conversation

@TATP-233

@TATP-233 TATP-233 commented Apr 9, 2026

Copy link
Copy Markdown
Collaborator

Summary

Fixes #168 - 收敛日志目录与 load_run 命名为单一真源

Changes

Core Changes

  1. Unified log directory naming: Added "_get_log_root()" helper functions to all training scripts that use "algo.algo_log_name" from config instead of hardcoded paths
  2. Removed hardcoded paths:
    • "train_rsl_rl.py": Removed hardcoded "logs/rsl_rl_train"
    • "train_appo.py": Removed hardcoded "logs/appo"
    • "train_mlx_ppo.py": Removed dependency on "training.log_root"
    • "play_interactive.py": Updated "resolve_checkpoint()" to accept algo_log_name parameter

Configuration Changes

  1. Single source for load_run: Moved "load_run" from "training" section to "algo" section in all configs:
    • "conf/ppo/config.yaml": Removed "training.load_run", kept "algo.load_run"
    • "conf/ppo/config_mlx.yaml": Removed "training.load_run" and "training.log_root", kept "algo.load_run"
    • "conf/appo/config.yaml": Removed "training.load_run", added "algo.load_run"
    • "conf/offpolicy/config.yaml": Removed "training.load_run"
    • "conf/offpolicy/algo/sac.yaml": Added "algo.load_run"
    • "conf/offpolicy/algo/td3.yaml": Added "algo.load_run"

Tests

  1. Added regression tests: 8 new tests for unified log directory and load_run resolution

Verification

  • All 69 tests in "tests/scripts/test_train_scripts.py" pass
  • Local test: "make test" passes

Closes #168

…truth

- Add _get_log_root() helper to use algo.algo_log_name instead of hardcoded paths
- Remove hardcoded 'rsl_rl_train' and 'appo' from training scripts
- Move load_run from training section to algo section (single source)
- Update all training scripts (train_rsl_rl, train_appo, train_mlx_ppo, play_interactive)
- Update all config files (ppo, appo, offpolicy, mlx)
- Add regression tests for unified log directory and load_run resolution

Closes #168
@TATP-233
TATP-233 merged commit bad3478 into main Apr 9, 2026
5 checks passed
@TATP-233
TATP-233 deleted the fix/issue-168-unify-log-dir branch April 9, 2026 16:45
TATP-233 added a commit that referenced this pull request May 4, 2026
fix(issue-168): Unify log directory and load_run as single source of truth
TATP-233 added a commit that referenced this pull request May 30, 2026
fix(issue-168): Unify log directory and load_run as single source of truth
TATP-233 added a commit that referenced this pull request Sep 4, 2026
fix(issue-168): Unify log directory and load_run as single source of truth
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Work: 收敛日志目录与 load_run 命名为单一真源

1 participant