Repository navigation
fix: align MLX PPO config with standard config - #196
Merged
Merged
Conversation
TATP-233
force-pushed
the
fix/issue-174-mlx-ppo-config-alignment
branch
2 times, most recently
from
April 10, 2026 07:38
13c8941 to
c33941f
Compare
Add missing fields to conf/ppo/config_mlx.yaml: - algo.save_interval: 100 - algo.resume: false - algo.checkpoint: -1 - training.device: mlx - training.task_step_tuning (migrated from hardcoded dict) Change fast_mode default from false to true to match standard config. Remove TASK_STEP_TUNING hardcoded dict from scripts/train_mlx_ppo.py. Fixes #174
TATP-233
force-pushed
the
fix/issue-174-mlx-ppo-config-alignment
branch
from
April 10, 2026 07:44
c33941f to
3132007
Compare
Jaui7
pushed a commit
that referenced
this pull request
Apr 14, 2026
…lignment fix: align MLX PPO config with standard config
TATP-233
added a commit
that referenced
this pull request
May 4, 2026
…lignment fix: align MLX PPO config with standard config
TATP-233
added a commit
that referenced
this pull request
May 30, 2026
…lignment fix: align MLX PPO config with standard config
TATP-233
added a commit
that referenced
this pull request
Sep 4, 2026
…lignment fix: align MLX PPO config with standard config
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #174
This PR aligns the MLX PPO configuration with the standard PPO configuration by adding missing fields and migrating hardcoded values to config.
Changes
conf/ppo/config_mlx.yaml
algo.save_interval: 100(was missing)algo.resume: false(was missing)algo.checkpoint: -1(was missing)training.device: mlx(was missing)training.task_step_tuningsection (migrated from hardcoded dict)algo.algorithm.fast_modefromfalsetotrue(to match standard config)scripts/train_mlx_ppo.py
TASK_STEP_TUNINGdictionaryChecklist