Repository navigation
refactor: unify observation dimension naming n_obs → obs_dim (Fixes #190) - #200
Merged
Merged
Conversation
Jaui7
pushed a commit
that referenced
this pull request
Apr 14, 2026
…ming refactor: unify observation dimension naming n_obs → obs_dim (Fixes #190)
TATP-233
added a commit
that referenced
this pull request
May 4, 2026
…ming refactor: unify observation dimension naming n_obs → obs_dim (Fixes #190)
TATP-233
added a commit
that referenced
this pull request
May 30, 2026
…ming refactor: unify observation dimension naming n_obs → obs_dim (Fixes #190)
TATP-233
added a commit
that referenced
this pull request
Sep 4, 2026
…ming refactor: unify observation dimension naming n_obs → obs_dim (Fixes #190)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Unified observation dimension naming from
n_obstoobs_dimacross the codebase to align with existing conventions (fast_sac/learner.pyalready usesobs_dim).Changes
Modified Files
src/unilab/algos/torch/fast_td3/learner.pyTD3Actor.__init__: parametern_obs→obs_dimsrc/unilab/algos/torch/common/networks.pyDistributionalQNetwork.__init__: parametern_obs→obs_dimCritic.__init__: parametern_obs→obs_dimsrc/unilab/utils/algo_utils.pybuild_actor()call site for TD3Actor (line 44)Verification
make test)ruff)Fixes #190