Skip to content

fix: respect motrix qpos metadata in set_state - #227

Merged
TATP-233 merged 1 commit into
mainfrom
fix/issue-226-motrix-set-state-metadata
Apr 12, 2026
Merged

TATP-233 merged 1 commit into
mainfrom
fix/issue-226-motrix-set-state-metadata

Conversation

@TATP-233

Copy link
Copy Markdown
Collaborator

Summary

  • replace hardcoded Motrix set_state quaternion/control offsets with metadata-driven floating-base and joint index mapping
  • support fixed-base robot base pose/velocity reads via the base link when the embodiment has no floating base
  • add Allegro fixed-base regression coverage alongside existing floating-base backend tests

Impact Scope

  • Motrix backend state restore for floating-base and fixed-base embodiments
  • fixed-base scenes with non-robot freejoints such as Allegro in-hand rotation
  • backend regression coverage in tests/base/test_sim_backend.py

Validation

  • UV_CACHE_DIR=.uv-cache make check
  • UV_CACHE_DIR=.uv-cache uv run pytest tests/base/test_sim_backend.py -m slow -k "motrix_backend_fixed_base or TestMotrixBasic or TestCrossBackend" -q
  • UV_CACHE_DIR=.uv-cache uv run pyright tests/base/test_sim_backend.py
  • UV_CACHE_DIR=.uv-cache uv run mypy tests/base/test_sim_backend.py

Notes

  • UV_CACHE_DIR=.uv-cache make test aborts during collection in tests/algos/test_mlx_ppo.py because the local MLX import crashes before test execution; this is environmental and unrelated to the Motrix backend change.

Fixes #226

@TATP-233
TATP-233 merged commit d84afd7 into main Apr 12, 2026
5 checks passed
@TATP-233
TATP-233 deleted the fix/issue-226-motrix-set-state-metadata branch April 12, 2026 07:49
TATP-233 added a commit that referenced this pull request May 4, 2026
…-metadata

fix: respect motrix qpos metadata in set_state
TATP-233 added a commit that referenced this pull request May 30, 2026
…-metadata

fix: respect motrix qpos metadata in set_state
TATP-233 added a commit that referenced this pull request Sep 4, 2026
…-metadata

fix: respect motrix qpos metadata in set_state
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: motrix_backend.set_state hardcodes qpos[3:7] as quaternion for all robots

1 participant