Repository navigation
chore(benchmark): delete device_info re-export shim, import unilab.utils.device directly (#2474) - #2491
Merged
Conversation
…ils.device directly (#2474)
This was referenced Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scripts/benchmark/core/device_info.py, a pure re-export shim ("moved in issue refactor: 掐断库层对 scripts/ 的反向依赖(device_info 提升入库) #1240") ofunilab.utils.devicenames with no added behavior.scripts/benchmark/core/__init__.py.scripts/benchmark/(compute/env/physics/rl/torch_env) to import directly fromunilab.utils.device.Files changed
scripts/benchmark/core/device_info.pyscripts/benchmark/core/__init__.pyscripts/benchmark/Driving issue / audit reference
unilab.utils.devicedirectly).Validation
Run inside a clean worktree based on
origin/main(9b7acd0):uv run pytest -q tests/utils/test_device.py tests/benchmark tests/utils/test_utils_package_policy.py→ 168 passed, 1 skippeduv run python scripts/benchmark/smoke_test.py→ [module-mode] Passed: 34/34, [script-mode] Passed: 35/35uv run ruff checkon all changed (added/modified) files → All checks passed!