Repository navigation
fix(tests): stabilize CUDA MPS CLI tests on macOS - #2511
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
short_temp_pathfixture that creates isolated/tmp/ucmps-*directories, keeping real AF_UNIX socket paths below macOS's 95-byte limit.start_daemon()tests use the existing Linux-host fixture so they exercise their intended start/topology branches on physical macOS hosts without weakening production platform checks.Linked Work
mainValidation
make test-allpassed on the final local head before this PR was created or updatedCommands actually run:
The focused module was also reproduced as failing before the fix: 13 failures with the default Darwin pytest temporary root and 4 failures with
TMPDIR=/tmp.Remote CI route:
main: current-head CI passed — https://github.com/Motphys/UniLab/actions/runs/39831552225 (coverage, benchmark-smoke, mypy, pyright, Ruff format/lint, and all four test shards).Impact
Artifacts
Checklist