Skip to content

fix: integrate env and playback correctness fixes - #2549

Merged
TATP-233 merged 20 commits into
mainfrom
dev/correctness-fixes-2538-2541
Oct 28, 2026
Merged

TATP-233 merged 20 commits into
mainfrom
dev/correctness-fixes-2538-2541

Conversation

@TATP-233

Copy link
Copy Markdown
Collaborator

Summary

  • apply cold-reset seeds before initialization and remove the unused reset options parameter without a compatibility layer
  • run RSL-RL/APPO/SAC/FlashSAC sim2sim preflight before playback environment construction
  • clarify full-width reset observations and fix the corresponding integration assertion
  • correct and strengthen the RL adapters import-boundary guard

Linked Work

Validation

  • make test-all passed on the final local head before this PR was created
  • Additional task-specific validation listed below
uv run pytest tests/envs/test_manager_based_rl_env.py -k reset
# 25 passed, 90 deselected

uv run pytest tests/visualization/test_interactive_playback.py tests/training/test_sim2sim_resolver.py
# 92 passed

uv run pytest tests/test_library_import_boundary.py
# 27 passed

uv run pytest tests/envs/test_observation_partial_reset.py -m slow -rs
# 1 passed (actually executed with MuJoCo)

make test-all
# make check passed
# 2849 passed, 62 skipped, 375 deselected
# benchmark smoke: 35/35 module-mode and 36/36 script-mode imports passed

Remote CI route: base main; current-head CI is pending and will be recorded on this PR.

Impact

  • Backend impact: both; common reset and playback paths
  • Platform impact: both
  • Training effect expected: yes; explicit cold-reset seeds now work and the unused reset options keyword is removed

Artifacts

None.

Checklist

  • Added and corrected regression tests
  • Updated the public reset contract documentation
  • Linked all four driving issues and integrated child PRs
  • No known follow-up work; final merge is reserved for the maintainer

TATP-233 and others added 20 commits October 28, 2026 20:31
fix(playback): validate sim2sim before env creation
test(boundary): cover adapter import boundaries
…ions

fix!: remove reset options parameter
…t-contract

docs(contract): clarify full-width reset observations
@TATP-233

Copy link
Copy Markdown
Collaborator Author

Current-head CI verification for 8a93187ab96b5ede353e2c2e28ec5962576e363c:

Local final-head gate: make test-all passed with 2849 passed, 62 skipped; focused reset/playback/boundary tests and the slow full-width integration test also passed.

@TATP-233
TATP-233 merged commit c21be23 into main Oct 28, 2026
12 checks passed
@TATP-233
TATP-233 deleted the dev/correctness-fixes-2538-2541 branch October 28, 2026 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant