Repository navigation
feat: G1 per-joint kp/kd domain randomization (issue #129) - #256
lemon-star608 wants to merge 1 commit into
Conversation
1d6fbf2 to
546b291
Compare
|
I don't think this change can merge in its current form because it breaks the backend capability contract instead of modeling it explicitly.
With that standard, the current shape has two problems:
The behavioral consequence is worse than style: the same env/domain-rand config now takes different reset paths on different backends without an explicit capability declaration or an explicit failure. In this repo, backend behavior is allowed to differ only when the difference is modeled as a real capability boundary and unsupported paths fail explicitly, rather than silently falling back. I think this needs to be reworked in one of these directions:
Separately, please do not solve this later by parsing XML/assets inside reset/domain-randomization hot paths. Even if we need model-derived actuator metadata, asset/XML access belongs in cold/init-time setup, not per-reset logic. |
Summary
Linked Work
Validation
make checkuv run pytest -m "not slow"Commands actually run:
# paste exact commands hereImpact
Checklist