Documentation and refactoring of suite2p/detection/sparsedetect.py#1085
Open
nspiller wants to merge 5 commits intoMouseLand:mainfrom
Open
Documentation and refactoring of suite2p/detection/sparsedetect.py#1085nspiller wants to merge 5 commits intoMouseLand:mainfrom
nspiller wants to merge 5 commits intoMouseLand:mainfrom
Conversation
0df2cc3 to
a993e7b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request does not change the functionality, we only restructured the code.
The settings that we usually use for our analysis did not work well anymore for some new data, therefore we wanted to understand in detail how the ROI detection is working. We documented the code in sparsery algorithm in that process. We think this may be useful for others.
This is relevant to #1067
Overview:
Specifically: