Repository navigation
Report unacknowledged Number writes as service errors - #4
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Run the existing Tag output validator for every confirmed Number write, including an empty reply, and propagate failure as ServiceValidationError. Keep send-only writes unchanged.
Validation: 18 targeted checks passed. A live HA pilot rejected a one-shot injected empty reply, then accepted a real device write. The injected reply does not claim firmware rejection.
Linux CI: 965 blocking tests passed; the same 17 known non-blocking findings as unchanged main remain. Hassfest passed. Test run: https://github.com/MrCodeLabs/ha-goecharger-api2/actions/runs/41515974089
Upstream synchronization #3 is merged. HACS fails only its repository-Issues check on the unchanged fork because Issues are disabled.