Repository navigation
Require a matching acknowledgement for requested PV responses - #6
Merged
Merged
Conversation
Owner
Author
|
Hallo @marq24, hier haben wir So kann eine Automation einen PV-Transfer erst nach echter Bestätigung als erfolgreich verbuchen. Der getrennte Vorschlag im Original ist marq24#188. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a caller requests a response, use the existing acknowledged write path for set_pv_data and reject missing or mismatched ids replies. Keep the existing response format and send-only calls.
Twenty targeted checks passed, including the real service and HTTP bridge with fake transport; unchanged main reproduces the failure. Regression cases extend existing test files.
Linux CI: 963 blocking tests passed; the same 17 known non-blocking findings as unchanged main remain. Hassfest passed. Test run: https://github.com/MrCodeLabs/ha-goecharger-api2/actions/runs/41516000470
Upstream synchronization #3 is merged. HACS fails only its repository-Issues check on the unchanged fork because Issues are disabled.