Syntax modernization: Convert var to let/const for better maintainability#684
Open
HendrikCromboom wants to merge 1 commit intoMrSwitch:mainfrom
Open
Syntax modernization: Convert var to let/const for better maintainability#684HendrikCromboom wants to merge 1 commit intoMrSwitch:mainfrom
HendrikCromboom wants to merge 1 commit intoMrSwitch:mainfrom
Conversation
MrSwitch
force-pushed
the
master
branch
3 times, most recently
from
dc9b406 to
f6f63dd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Summary
This PR refactors variable declarations across the codebase by replacing
varwithletorconstto align with modern JavaScript standards. This improves scoping, readability, and prevents potential bugs related to variable hoisting.✅ Changes Made
varwithletorconstbased on reassignment behavior.src/tests/modules/🧪 How to Test
npm test
Manually inspect key files for correct scoping and behavior.
Confirm no regressions in OAuth flows or provider modules.
📚 Context
This change is part of a broader effort to modernize the codebase and improve maintainability. It also prepares the project for future ES6+ enhancements like tree-shaking and modular imports.
🔗 Related Issues
None
🙌 Acknowledgements
Thanks to the community for highlighting this opportunity for improvement!
📣 Notes for Reviewers
Let me know if you'd prefer this refactor split into smaller PRs by module.
Happy to add JSDoc comments or ESLint rules in a follow-up PR.