Fix: add stable redirect_uri for Google OAuth to avoid redirect_uri_mismatch#703
Open
ashfaq3112 wants to merge 2 commits intoMrSwitch:mainfrom
Open
Fix: add stable redirect_uri for Google OAuth to avoid redirect_uri_mismatch#703ashfaq3112 wants to merge 2 commits intoMrSwitch:mainfrom
ashfaq3112 wants to merge 2 commits intoMrSwitch:mainfrom
Conversation
MrSwitch
force-pushed
the
master
branch
3 times, most recently
from
dc9b406 to
f6f63dd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello.js currently generates a dynamic redirect URI based on window.location,
which causes Google OAuth to return redirect_uri_mismatch unless the user manually
copies the redirect URL into Google Cloud Console for each page.
This PR introduces a stable redirect URI for the Google provider:
This makes Google OAuth predictable, prevents mismatch errors, and follows how
modern libraries like Firebase and Auth0 use a fixed callback path.
Changes:
Fixes #