Skip to content

Test #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kzubatov wants to merge 6 commits into from
Closed

Test #49

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
996465d
fix PR comments
kzubatov Nov 2, 2025
50dd149
fix comments for private repos
kzubatov Nov 2, 2025
efd4297
i hate yaml
kzubatov Nov 2, 2025
a0685b1
ok.lets.use.this.param.because.why.not
kzubatov Nov 2, 2025
87ad945
add minor fixes for lint and format
kzubatov Nov 3, 2025
2c788e4
stupid commit to test CI
kzubatov Oct 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/format.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ permissions:
contents: read

jobs:
check-format-and-tidy:
check-format:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
Expand Down
7 changes: 2 additions & 5 deletions .github/workflows/lint.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,8 @@ on:
paths:
- '**.hpp'
- '**.cpp'
- '**.clang-format'
- '**.clang-tidy'

permissions:
contents: read

jobs:
check-format-and-tidy:
runs-on: ubuntu-latest
Expand Down Expand Up @@ -47,11 +43,12 @@ jobs:
cmake_command: |
cmake -Bbuild -S. -DCMAKE_EXPORT_COMPILE_COMMANDS=on -DGLFW_BUILD_WAYLAND=off
clang_tidy_checks: '' # Use closest .clang-tidy config, not some weird default
split_workflow: true # So that comments work with fork PRs
split_workflow: ${{ github.event.pull_request.head.repo.fork }} # So that comments work with fork PRs

# Upload review results as artifacts, a different workflow posts them
# as comments. This is required due to security stuff.
- uses: ZedThree/clang-tidy-review/upload@v0.21.0
id: upload-review

# If there are any comments, fail the check
- if: steps.review.outputs.total_comments > 0
Expand Down
4 changes: 2 additions & 2 deletions samples/shadowmap/App.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,10 @@ App::App()
auto instExts = windowing.getRequiredVulkanInstanceExtensions();
renderer->initVulkan(instExts);

auto surface = mainWindow->createVkSurface(etna::get_context().getInstance());
auto surface_ = mainWindow->createVkSurface(etna::get_context().getInstance());

@github-actions github-actions Bot Nov 2, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: invalid case style for variable 'surface_' [readability-identifier-naming]

Suggested change
auto surface_ = mainWindow->createVkSurface(etna::get_context().getInstance());
auto surface = mainWindow->createVkSurface(etna::get_context().getInstance());

samples/shadowmap/App.cpp:36:

-     std::move(surface_), [window = mainWindow.get()]() { return window->getResolution(); });
+     std::move(surface), [window = mainWindow.get()]() { return window->getResolution(); });


renderer->initFrameDelivery(
std::move(surface), [window = mainWindow.get()]() { return window->getResolution(); });
std::move(surface_), [window = mainWindow.get()]() { return window->getResolution(); });

// TODO: this is bad design, this initialization is dependent on the current ImGui context, but we
// pass it implicitly here instead of explicitly. Beware if trying to do something tricky.
Expand Down
Loading