-
Notifications
You must be signed in to change notification settings - Fork 6
Refactor and enhance modals #1226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for documentcloud-frontend-next ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
I've identified a few more stories that need tweaked. |
068977a to
e2a287a
Compare
|
Let's wait until #1229 is merged for this one. It hits enough files that there's a good chance we have conflicts, and those will be easier to deal with post-merge, I think. |
I'm always using the wrong node version on my system, so this gives more hints for which node to build for
e2a287a to
e46e274
Compare
…o allanlasser/embed-modal-size
|
Thanks for flagging these examples! I'll do a more careful pass to enforce aspect ratios and set max-widths on these modals. |




This one was a bit of a journey:
48remmax-width.fillScreenlayout mode.kit.css, which let me remove style rules from many of our form components.End results:
Two other small tweaks:
.nvmrcso my system recognizes the Node version the project uses.npm i, the package-lock file was updated with peer dependency annotations. This was unintentional.Screenshots
Mobile sharing dialog now uses flex-wrap with a vertical overflow:

Larger sharing modal that fills viewport:

Note sharing modal at larger size:
