Protect access to invoice data #554
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've observed a crash in our Stripe webhook handler for `charge_succeeded` events. This guards against unexpectedly shaped invoice data in our handler.
allanlasser
force-pushed
the
protected-invoice-access
branch
from
9a03f36 to
af8f07f
Compare
duckduckgrayduck
approved these changes
Jan 27, 2026
duckduckgrayduck
temporarily deployed
to
squarelet-pi-protected--cgkzcw
duckduckgrayduck
requested changes
Jan 27, 2026
Contributor
duckduckgrayduck
left a comment
duckduckgrayduck
left a comment
There was a problem hiding this comment.
I fixed pylint issues, but it appears that test_tasks is facing a pylint issue
************* Module squarelet.organizations.tests.test_tasks
squarelet/organizations/tests/test_tasks.py:44:0: C0302: Too many lines in module (1020/1000) (too-many-lines)
We can choose to silence this error or refactor these tests to split them up. I'll leave that to you.
Member
Author
|
Hmm, definitely a sign we need a refactor, but I don't want to introduce a bunch of unrelated changes in this commit. I will suppress the warning here and open an issue to refactor the |
Member
Author
duckduckgrayduck
approved these changes
Jan 28, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've observed a crash in our Stripe webhook handler for
charge_succeededevents. This guards against unexpectedly shaped invoice data in our handler.https://muckrock.sentry.io/issues/7116551588/?project=1422309&query=is%3Aunresolved%20issue.priority%3A%5Bhigh%2C%20medium%5D&referrer=issue-stream