Repository navigation
fix: keep the input list apart from the cache helper in the flake check - #40
Merged
Muddyblack merged 1 commit intoOct 19, 2026
Conversation
Since #35 the flake check builds its command as NIXDATIFIER_IGNORE_INPUTS='''/…/tools/sh/run' cached 'flake:…' 30 -- … The quoted list and the quoted helper path form one word, so the path becomes the variable's value and bash runs `cached` as the command: "cached: command not found", and no update is ever reported. End the prefix with a space, as the partial probe already does. The cache scope trims the prefix, so existing cache entries stay valid. Fixes #38 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Muddyblack
approved these changes
Oct 19, 2026
Owner
|
thank you :=) |
Chr1ssi
added a commit
to Chr1ssi/Nix
that referenced
this pull request
Oct 19, 2026
The fix landed upstream as Muddyblack/nixdatifier#40 (7bbc595), so the local substituteInPlace no longer matches and --replace-fail stopped the build as intended. The module is back to plain upstream. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #38.
Since #35,
checkFlakeUpdates()builds its command asprobeEnvends with the quoted input list and no space, so the list and the quoted helper path form a single word. The path becomes the variable's value, and bash runscachedas the command (cached: command not found, exit 127). Every flake check fails as soon as a flake path is set, whatever the list contains, so no update is ever reported.The fix ends
probeEnvwith a space, as the partial probe (NIXDATIFIER_ONLY_INPUTS=…) already does. The cache scope usesprobeEnv.trim(), so its key stays the same and existing cache entries stay valid.Tests
test_flake_check_keeps_the_input_list_apart_from_the_helperintests/tst_Engine.qmlchecks the command for an empty list and fornur. Without the fix it fails, and the failure shows the glued string. With the fix it passes.nix develop --command bash tests/run.sh: 91 helper tests OK, 124 QML tests passed.nix develop --command bash scripts/lint.sh: all checks passed.Side note:
nix flake check(checks.tests) fails on unmodifiedmastertoo. The helpers start with#!/usr/bin/env bash, and/usr/bin/envdoesn't exist in the build sandbox. CI isn't affected because it runs the scripts throughnix develop.🤖 Generated with Claude Code