fix(security): Prevent DOM XSS in Markdown, diff, and regex views - #7
Draft
cursor[bot] wants to merge 1 commit into
Draft
fix(security): Prevent DOM XSS in Markdown, diff, and regex views#7cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
Prevent DOM XSS when user content is rendered via innerHTML in Markdown preview, text diff, and regex match display. Co-authored-by: Muki182 <Muki182@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Several tools wrote user-controlled strings into
innerHTMLwithout escaping, which allows DOM-based cross-site scripting in the same origin (for example pasting# <img src=x onerror=alert(1)>into Markdown preview, or the same payload into a text-diff line).Changes
escapeHtml()and use it for all user-derived segments rendered intoinnerHTMLin text diff and regex results.Validation
Impact
Removes a client-side XSS surface for users who paste untrusted content into these panels.