418 asset max size and esdl attribute used#419
Merged
KobusVanRooyen merged 22 commits intomainfrom Mar 10, 2026
Merged
Conversation
tolga-akan
reviewed
Feb 4, 2026
tolga-akan
reviewed
Feb 5, 2026
Collaborator
FJanssen-TNO
left a comment
FJanssen-TNO
left a comment
There was a problem hiding this comment.
The profile & range constraints indeed make it a bit more complicating, but I do think you found a proper way around it.
See a few generic comments from me below, besides that I think the structure of the new approach is okay.
KobusVanRooyen
commented
Feb 27, 2026
Collaborator
FJanssen-TNO
left a comment
FJanssen-TNO
left a comment
There was a problem hiding this comment.
I haven't check asset_Sizing_mixin and potential_errors yet nor the tests. But I cannot finish the checks today any further than this.
Collaborator
Author
|
@FJanssen-TNO ready for review again |
FJanssen-TNO
approved these changes
Mar 5, 2026
* Allow use pipeDiameterconstraint for specifying pipe upper DN size for optional pipes * allow pipe DN to be used if a pipeDiameterconstraint does not exist
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the esdl input variable used in MESIDO to limit the max size of an asset. Details in https://365tno.sharepoint.com/:x:/r/teams/P060.55186/TeamDocuments/Team/Work/Backend/Optimiser/ESDL%20compatibility%2020260121.xlsx?d=wbaacaf23f58f458091a47213eb3bedcd&csf=1&web=1&e=9LCNA7