Heat buffer efficiency by tolga-akan · Pull Request #427 · Multi-Energy-Systems-Optimization/mesido

tolga-akan · 2026-02-09T13:13:41Z

Done:

Read heat_loss_coefficient of heat_buffer from dischargeEfficiency attributes in esdl. The asset attribute "dischargeEfficiency" represents the fraction of stored heat that is lost per day. If this attribute is not provided in esdl, a default heat loss rate of 1% per day is used. The value is converted to a per‑second loss factor.
Modify the old tests with heat buffer asset. Make it adjusted with new heat_loss_coefficient definition. Add a check to ensure that regarding attribute is read from esdl

…s lost per day

# Conflicts: # CHANGELOG.md

tolga-akan · 2026-03-09T10:31:52Z

@FJanssen-TNO Ready for review

FJanssen-TNO · 2026-03-10T12:20:24Z

src/mesido/esdl/esdl_heat_model.py

            else 10.0e6
        )

+        # The asset attribute "dischargeEfficiency" represents the fraction of stored heat


The two name conventions conflict

efficiency vs fraction

dischargeEfficiency vs stored heat lost
I would expect that if I put in 98%, that only 2% is lost during the day.

"heat_loss_efficiency " is renamed as "heat_loss_coefficient". With this naming, we are aligned with the "efficiency attribute" definitions of esdl. Besides, using heat_loss_coefficienct looks more logical now

FJanssen-TNO · 2026-03-10T12:20:58Z

src/mesido/esdl/esdl_heat_model.py

+        # that is lost per day. If this attribute is not provided in esdl, a default heat loss rate
+        # of 1% per day is used. The value is converted to a per‑second loss factor.


The comment "if this attribute is not provided ...." can be removed, this can be seen below.

rest of the comment is removed

FJanssen-TNO · 2026-03-10T12:22:08Z

src/mesido/esdl/esdl_heat_model.py

+        # The asset attribute "dischargeEfficiency" represents the fraction of stored heat
+        # that is lost per day. If this attribute is not provided in esdl, a default heat loss rate
+        # of 1% per day is used. The value is converted to a per‑second loss factor.
+        heat_loss_efficiency = (


Name convention is confusing: heat loss efficiency is confliction, so either efficiency or heat loss coefficient. The latter is actually what you are using.

renamed as "heat_loss_coefficient"

FJanssen-TNO · 2026-03-10T12:23:56Z

src/mesido/pycml/component_library/milp/heat/heat_buffer.py

        self.height = 5.0
        self.radius = 10.0
        self.volume = math.pi * self.radius**2 * self.height
-        self.heat_loss_coeff = 2 * self.heat_transfer_coeff / (self.radius * self.rho * self.cp)


maybe keep this old line as commented code as in the future we might want to use a heat transfer coefficient together with its dimensions.

old definition of "heat_loss_coefficient" is added back again as a comment

FJanssen-TNO · 2026-03-10T12:29:05Z

tests/test_max_size_and_optional_assets.py

+        # Test that if heat_loss_efficiency is incorporated into heat loss calculation of buffer
+        esdl_asset = solution.esdl_assets[solution.esdl_asset_name_to_id_map["HeatStorage_74c1"]]
+        np.testing.assert_allclose(
+            parameters["HeatStorage_74c1.heat_loss_efficiency"],
+            esdl_asset.attributes["dischargeEfficiency"] / (24.0 * 3600.0),
+        )
+        np.testing.assert_allclose(
+            results["HeatStorage_74c1.Heat_loss"],
+            results["HeatStorage_74c1.Stored_heat"]
+            * parameters["HeatStorage_74c1.heat_loss_efficiency"],
+        )
+


This test is about sizing. The checks that you have done here, should be for instance in the other test where you are checking the buffer.

checks are removed from "test_max_size_and_optional_assets.py" and placed into "test_warmingup_unit_cases.py". Anyways, one of the check was already done in test_warmingup_unit_cases. I have only added check related to to "dischargeEfficiency" attribute

FJanssen-TNO · 2026-03-10T12:34:20Z

src/mesido/esdl/esdl_heat_model.py

+        # that is lost per day. If this attribute is not provided in esdl, a default heat loss rate
+        # of 1% per day is used. The value is converted to a per‑second loss factor.
+        heat_loss_efficiency = (
+            asset.attributes.get("dischargeEfficiency") / (24.0 * 3600.0)


Suggested change

asset.attributes.get("dischargeEfficiency") / (24.0 * 3600.0)

asset.attributes.get("dischargeEfficiency") /100 / (24.0 * 3600.0)

Don't do this suggestion, appearantly efficiencies are now always fractions in esdl. Lets atleast in our own code be clear and name it fraction/coefficient etc.

I renamed "heat_loss_efficiency " as "heat_loss_coefficient". Hence, this aligns with the definition of efficiency attributes used in esdl

FJanssen-TNO · 2026-03-10T12:42:55Z

CHANGELOG.md

 ## Added
 - Parsing of ensemble profiles when using input profiles from csv.
 - Maximum profile constraint for PV asset is considered in PV sizing
+- heat_loss_efficiency of HeatStorage is read from dischargeEfficiency attribute in esdl


Suggested change

- heat_loss_efficiency of HeatStorage is read from dischargeEfficiency attribute in esdl

- DischargeEfficiency is parsed from HeatStorage assets in ESDL to a heat loss coefficient

suggestion is implemented

# Conflicts: # CHANGELOG.md

tolga-akan · 2026-03-12T12:28:34Z

@FJanssen-TNO Ready for review

tolga-akan added 3 commits February 9, 2026 14:06

heat transfer coefficient is read from discharge efficiency

1220e6f

Merge branch 'main' into heat_buffer_efficiency

ccf8a94

change log is updated

2035f7f

tolga-akan marked this pull request as ready for review February 9, 2026 13:14

tolga-akan requested review from FJanssen-TNO, KobusVanRooyen and jimrojerTNO as code owners February 9, 2026 13:14

"dischargeEfficiency" represents the percentage of stored heat that i…

5f08353

…s lost per day

tolga-akan closed this Feb 27, 2026

tolga-akan reopened this Feb 27, 2026

Merge branch 'main' into heat_buffer_efficiency

6d790f4

# Conflicts: # CHANGELOG.md

tolga-akan marked this pull request as draft February 27, 2026 11:01

tolga-akan marked this pull request as ready for review February 27, 2026 12:02

tolga-akan added 3 commits March 6, 2026 18:15

Merge branch 'main' into heat_buffer_efficiency

a115894

# Conflicts: # CHANGELOG.md

final checks done

87da386

typo

67b4739

FJanssen-TNO reviewed Mar 10, 2026

View reviewed changes

tolga-akan added 3 commits March 11, 2026 10:51

Merge branch 'main' into heat_buffer_efficiency

b2ad759

# Conflicts: # CHANGELOG.md

PR comments update

0a67d4d

comment update

5a7200a

		# that is lost per day. If this attribute is not provided in esdl, a default heat loss rate
		# of 1% per day is used. The value is converted to a per‑second loss factor.

	asset.attributes.get("dischargeEfficiency") / (24.0 * 3600.0)
	asset.attributes.get("dischargeEfficiency") /100 / (24.0 * 3600.0)

	- heat_loss_efficiency of HeatStorage is read from dischargeEfficiency attribute in esdl
	- DischargeEfficiency is parsed from HeatStorage assets in ESDL to a heat loss coefficient

Conversation

tolga-akan commented Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tolga-akan commented Mar 9, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tolga-akan Mar 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tolga-akan Mar 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tolga-akan commented Mar 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

tolga-akan commented Feb 9, 2026 •

edited

Loading

tolga-akan Mar 11, 2026 •

edited

Loading

tolga-akan Mar 11, 2026 •

edited

Loading