Skip to content

feat: implement Tab Service v2 and replace old tab manager #276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
devin-ai-integration wants to merge 98 commits into
base: main
Choose a base branch
from
Open

feat: implement Tab Service v2 and replace old tab manager #276

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
98 commits
Select commit Hold shift + click to select a range
4160358
feat: design
iamEvanYT May 24, 2026
596d72f
feat: implement Tab Service v2 architecture
devin-ai-integration[bot] May 24, 2026
01aab6a
fix: prevent stale destroy listeners and fix unpinToTabList iteration
devin-ai-integration[bot] May 24, 2026
2c3dfd4
fix: resolve Greptile review issues (wasActive ordering, stale layout…
devin-ai-integration[bot] May 24, 2026
e756778
fix: use webContents.close() instead of view.destroy() in Tab.teardow…
devin-ai-integration[bot] May 24, 2026
5f527dc
feat: replace old tab manager with TabService v2
devin-ai-integration[bot] May 24, 2026
6ba48e5
fix: activateTab now updates view visibility and bounds
devin-ai-integration[bot] May 24, 2026
b803f12
fix: emit structural change on tab activation for renderer sync
devin-ai-integration[bot] May 24, 2026
7763ce2
fix: add pinned tabs persistence (load from DB, save on create/remove…
devin-ai-integration[bot] May 24, 2026
414699c
feat: implement tab sync, web context menu, error page, target URL
devin-ai-integration[bot] May 24, 2026
28ac108
fix: complete audit — loading state, fullscreen, auto-sleep, backgrou…
devin-ai-integration[bot] May 24, 2026
7f9ec7d
style: fix format for executeJavaScript call
devin-ai-integration[bot] May 24, 2026
cd1a601
fix: tab sync across windows and archive timer
devin-ai-integration[bot] May 24, 2026
d3e0007
fix: update lastActiveAt when tab becomes hidden, not just on activation
devin-ai-integration[bot] May 24, 2026
93af42d
fix: STAW focus loop and placeholder rounded corners
devin-ai-integration[bot] May 24, 2026
12479b4
fix: STAW focus handler - use immediate sync move to avoid focus races
devin-ai-integration[bot] May 24, 2026
032b8df
fix: STAW infinite loop - remove relocateDisplacedTabs, use debounced…
devin-ai-integration[bot] May 24, 2026
c88b06b
fix: re-focus target window after tab is moved and visible
devin-ai-integration[bot] May 24, 2026
9b0d0e0
fix: STAW focus races - debounce at start + focus layer via LayerManager
devin-ai-integration[bot] May 24, 2026
46e4239
fix: defer LayerManager.reallocateFocus() until window is focused
devin-ai-integration[bot] May 24, 2026
90b526b
fix: clear pending focus reallocation when a layer is explicitly focused
devin-ai-integration[bot] May 24, 2026
aecba3d
feat: release synced tab back to other window when deactivated
devin-ai-integration[bot] May 24, 2026
9114266
fix: only focus tab layer when its window is already focused
devin-ai-integration[bot] May 24, 2026
afa316f
fix: remove redundant rounded-md from placeholder img
devin-ai-integration[bot] May 24, 2026
5ad9ab9
fix: tab persistence broken - unit mismatch + stale windowGroupId
devin-ai-integration[bot] May 24, 2026
10a084c
fix: 'Profile not found' crash during session restore
devin-ai-integration[bot] May 24, 2026
f6abde4
fix: wake sleeping tabs on activation, fix restored tabs showing blank
devin-ai-integration[bot] May 25, 2026
57caf2a
fix: don't wake sleeping tabs on initialization, add re-entry guard
devin-ai-integration[bot] May 25, 2026
3c3bd47
refactor: extract concerns from tab-service into modular modules
devin-ai-integration[bot] May 25, 2026
b62e88a
fix: put-to-sleep no longer destroys the tab
devin-ai-integration[bot] May 25, 2026
9547257
fix: relocate synced tabs to surviving windows on window close
devin-ai-integration[bot] May 25, 2026
242d64c
refactor: add isTabSynced() utility function
devin-ai-integration[bot] May 25, 2026
b289ce2
fix: update extensions window mapping on tab transfer between windows
devin-ai-integration[bot] May 25, 2026
5c67b5b
fix: guard fullscreen listener disconnect against destroyed window
devin-ai-integration[bot] May 25, 2026
1f6afa9
refactor: patch extensions store directly instead of removeTab+addTab
devin-ai-integration[bot] May 25, 2026
58a35ee
style: format long type cast line
devin-ai-integration[bot] May 25, 2026
d789546
fix: resolve Greptile review issues — persistence & structural change…
devin-ai-integration[bot] May 25, 2026
3ab1567
fix: space switching visibility + pinned tab sync across spaces
devin-ai-integration[bot] May 25, 2026
44f8ab3
fix: pinned tabs auto-relocate back on space switch
devin-ai-integration[bot] May 25, 2026
796aeea
fix: STAW + space move interaction bugs
devin-ai-integration[bot] May 25, 2026
986a899
fix: properly hide tab and clear focused refs on space move
devin-ai-integration[bot] May 25, 2026
237f4bf
fix: pinned tab relocation handles tab in other window (STAW thumbnai…
devin-ai-integration[bot] May 25, 2026
88f0615
refactor: cleanup and correctness improvements
devin-ai-integration[bot] May 25, 2026
333bcfc
fix: address Devin Review findings + add ACTIVATE_TAB_ON_SPACE_SWITCH…
devin-ai-integration[bot] May 25, 2026
f58d6fb
feat: persist pageState in nav history with 10s polling
devin-ai-integration[bot] May 25, 2026
69d36fd
fix: resolve CodeRabbit review issues
devin-ai-integration[bot] May 25, 2026
6222a3c
fix: reorder pinned-tab-owned tabs by pinned tab position
devin-ai-integration[bot] May 25, 2026
3f956d4
fix: Ctrl+Tab now wakes sleeping tabs
devin-ai-integration[bot] May 25, 2026
0938ee9
fix: woken tabs from Ctrl+Tab now show immediately
devin-ai-integration[bot] May 25, 2026
67d6067
fix: pinned tabs only move to a space when explicitly activated
devin-ai-integration[bot] May 25, 2026
dfd8a28
feat: pinned tabs persist across spaces once activated
devin-ai-integration[bot] May 25, 2026
81a24d3
Revert "feat: pinned tabs persist across spaces once activated"
devin-ai-integration[bot] May 25, 2026
c3b1389
perf: optimize Tab Service with indexes and cached lookups
devin-ai-integration[bot] May 25, 2026
ec2c2d9
refactor: TabLayout per window-space (Phase 1)
devin-ai-integration[bot] May 25, 2026
199d94e
refactor: bounds calculation split (Phase 2)
devin-ai-integration[bot] May 25, 2026
70b4018
refactor: STAW multi-layout membership infrastructure (Phase 3)
devin-ai-integration[bot] May 25, 2026
e1db302
refactor: pinned tab nodes in all profile layouts (Phase 4)
devin-ai-integration[bot] May 25, 2026
7d5630a
refactor: layout-level visibility & space switching (Phase 5)
devin-ai-integration[bot] May 25, 2026
a316fc5
fix: pinned tab activation across spaces/windows
devin-ai-integration[bot] May 25, 2026
e65ca2d
fix: pinned tab activation no longer switches window's space
devin-ai-integration[bot] May 25, 2026
4b00419
fix: pinned tab cross-window activation no longer triggers space switch
devin-ai-integration[bot] May 25, 2026
b49768c
fix: moveTabToSpace now clears visibility in all windows with shared …
devin-ai-integration[bot] May 25, 2026
71cd2f4
fix: send placeholder to old window when pinned tab view moves cross-…
devin-ai-integration[bot] May 25, 2026
2fe7eff
fix: explicitly hide tab layer on moveTabToSpace before reactivation
devin-ai-integration[bot] May 25, 2026
0999eb6
fix: never call migrateTabBetweenLayouts for pinned tabs
devin-ai-integration[bot] May 25, 2026
1afef27
refactor: remove migrateTabBetweenLayouts, use multi-layout membership
devin-ai-integration[bot] May 25, 2026
13b4497
fix: correct layout lookups for pinned tabs & clean up tab-service
devin-ai-integration[bot] May 25, 2026
6fad58f
fix: pinned node not found in newly created layouts after cross-windo…
devin-ai-integration[bot] May 25, 2026
21f7a95
refactor: store layoutNode directly on PinnedTab for O(1) propagation
devin-ai-integration[bot] May 25, 2026
f7538ec
fix: pinned tab ordering uses layout nodes instead of tab-window index
devin-ai-integration[bot] May 25, 2026
0edb339
perf: optimize IPC throttling, serialization cache, and hot paths
devin-ai-integration[bot] May 25, 2026
f8e353e
feat: unified tab context menu for normal and pinned tabs
devin-ai-integration[bot] May 25, 2026
066a5eb
fix: invalidate serialization cache on space change
devin-ai-integration[bot] May 25, 2026
cb742fb
fix: mute context menu now updates tab state and renderer
devin-ai-integration[bot] May 25, 2026
71a8336
fix: evict IPC cache on structural changes + context menu space fixes
devin-ai-integration[bot] May 25, 2026
8758aa5
fix: duplicate tab appears directly below source tab
devin-ai-integration[bot] May 25, 2026
38f51b9
fix: normalize positions after duplicate tab creation
devin-ai-integration[bot] May 25, 2026
acf1bed
fix: address Devin Review issues (PiP counter, window open, preload a…
devin-ai-integration[bot] May 25, 2026
d9a735e
style: fix formatting for duplicate tab handler
devin-ai-integration[bot] May 25, 2026
d1c7ee7
fix: wasActive detection when active node already destroyed
devin-ai-integration[bot] May 25, 2026
7b38870
fix: remove auto-activate-next after moveTabToSpace
devin-ai-integration[bot] May 25, 2026
2f0b468
fix: resolve CodeRabbit and Greptile review issues
devin-ai-integration[bot] May 25, 2026
29ce6d0
fix: add post-await destruction guard in doubleClickPinnedTab
devin-ai-integration[bot] May 25, 2026
0e26929
feat: `Tab.notifyExtensionsOfChanges()` and `TabService.getTabsInWind…
iamEvanYT May 26, 2026
8c99710
feat: wire up notifyExtensionsOfChanges for extension state updates
devin-ai-integration[bot] May 26, 2026
b3f15ad
fix: correct migration checklist - tab-updated WAS emitted in old code
devin-ai-integration[bot] May 26, 2026
af178e2
fix: getTabsInWindowProfile uses tab.position for deterministic ordering
devin-ai-integration[bot] May 26, 2026
9d1b851
docs: add AGENTS.md for tab-service
devin-ai-integration[bot] May 26, 2026
f7913b5
fix: simplify getTabsInWindowProfile + add notifyIndexChanges to moveTab
devin-ai-integration[bot] May 26, 2026
072a819
chore: bump electron chrome extensions
iamEvanYT May 26, 2026
a0057b0
fix: extensions createWindow does not create any tabs successfully
iamEvanYT May 26, 2026
0c3c29d
fixes
iamEvanYT May 26, 2026
91c0377
refactor: update tab lifecycle timer to use ArchiveTabValueMap and Sl…
iamEvanYT May 26, 2026
56d5337
fix: greptile identified issue
iamEvanYT May 26, 2026
acaeaec
refactor(renderer): align tab layout node naming and remove dead prov…
iamEvanYT May 26, 2026
da1cf6b
chore: format
iamEvanYT May 26, 2026
3eec6ee
fix: address tab service review blockers
devin-ai-integration[bot] May 26, 2026
94490c3
fix: codex discovered issues
iamEvanYT May 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions bun.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading