-
Notifications
You must be signed in to change notification settings - Fork 59
Add multi-engine search settings, onboarding, and custom search support #278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
JaggedGem
wants to merge
9
commits into
MultiboxLabs:main
Choose a base branch
from
JaggedGem:feature/multiple-search-engines
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
f8a4ab0
feat: add DuckDuckGo as a search engine
JaggedGem 781a78f
refactor: change old omnibox to use the same search provider as the n…
JaggedGem cc9f90b
feat: add settings options for setting the default search engine
JaggedGem d160a6d
feat: add yandex as a search engine option
JaggedGem f47c7d7
feat: add search providers to onboarding flow
JaggedGem 6a51160
feat: add support for custom search engines via user-provided URLs wi…
JaggedGem 5530315
feat: enhance search settings management and custom search functionality
JaggedGem df0a465
fix(search-settings): sync startup repairs and add DuckDuckGo AI pref…
JaggedGem 54a22df
feat: implement suggestion relevance mapping and URL normalization ut…
JaggedGem File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
repairInvalidActiveSearchConfigurationmutatesbasicSettingsCurrentValuesand persists the corrected engine to disk, but never callsfireOnSettingsChanged()orsettingsEmitter.emit("settings-changed"). The repair runs aftersettingsCachedPromiseresolves, which can happen after the renderer has already calledgetSearchSettingsSnapshotSyncduring module initialization. In that sequence the renderer initializescurrentSearchSettingsto the invalid (pre-repair) value and is never told to refresh it — so the settings UI continues to show the stale engine selection while the main process has silently moved to the default.