Guarantee the push service worker is included in release images - #36
Merged
Muukuro merged 1 commit intoJul 24, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
public/assets incidental to the builder stage and risked releasing images withoutpublic/push-sw.js, breaking browser push notifications.Description
public/from the builder into./.next/standalone/publicin the final Docker stage and add a build-time assertiontest -f ./.next/standalone/public/push-sw.jsso the Docker build fails if the push service worker is missing, while preserving the reduced standalone image layout.Testing
git diff --checkandnpm run lint, both succeeded;npm run buildcould not fully complete here because the environment could not fetch Google Fonts; and a full Docker image build could not be run because the Docker CLI is not available in this environment.Codex Task