Skip to content

feat: add recording audio mute control - #25

Open
My-Denia wants to merge 4 commits into
feat/ai-editionfrom
feat/1104-recording-audio-mute
Open

My-Denia wants to merge 4 commits into
feat/ai-editionfrom
feat/1104-recording-audio-mute

Conversation

@My-Denia

@My-Denia My-Denia commented Oct 12, 2026 •

Copy link
Copy Markdown
Owner

Summary

Add a persistent Audio pane control to mute the original recording in preview and all export paths. The setting defaults off, and imported music and voiceover remain audible.

Related issue

Refs getopenscreen#1104

Type of change

  • Bug fix
  • Feature
  • Enhancement
  • Documentation
  • Refactor / maintenance
  • Performance
  • Security

Release impact

  • Patch
  • Minor
  • Major / breaking change
  • No release note needed

Desktop impact

  • Windows
  • macOS
  • Linux
  • Installer / packaging
  • Not platform-specific

Screenshots / video

No screenshot: this execution host exposes no display/video controller and the Electron renderer did not open, so no actual preview/export audio result is claimed.

Testing

  • npm run build-vite passed.
  • App and test TypeScript checks passed; npm run i18n:check passed.
  • Focused audio/export tests passed (243 tests, plus 48 playback/fallback tests).
  • Changed-file Biome check and the configured pre-commit hook passed.
  • Full Windows Vitest run: 4,533 passed, 10 skipped; 5 unrelated .github/scripts failures remain locally (the stable-release-notes text assertion expects LF while the Windows checkout is CRLF; the set-release-version suite fails collection with SyntaxError: Invalid or unexpected token).
  • Real Electron preview/export smoke remains blocked: the GPU subprocess exited -1073741515 (STATUS_DLL_NOT_FOUND). Available Windows event/SxS logs do not name the missing dynamic DLL; a static import scan found no unresolved direct imports in the packaged Electron EXE/DLL files. No real preview/export, camera, or hardware behavior is claimed.

Copilot AI balanced review requested due to automatic review settings October 12, 2026 14:30

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@coderabbitai

coderabbitai Bot commented Oct 12, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: a66dc1b0-e1bf-4190-82c1-0f8aeb5ab024

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 12, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-12T14:44:33.182206Z 97e7939 New commits
🔒 Security Review ✅ Completed 2026-10-12T14:33:14.740655Z 20114d9 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 20114d9c66

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/components/ai-edition/RightPanes.tsx

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants