fix: canceled STT uploads, note autosave races, exports, and search - #42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scriber could upload canceled recordings, lose a reverted Meeting note during shutdown, truncate exported Meeting duration, and return unrelated history entries for a percent-sign search.
Fixes
CancelFrameacross the shared cloud adapter, AssemblyAI, Mistral, Modulate, Smallest, and Soniox. Release adopted Rust WAV artifacts without opening or uploading them. Close recording-gate state without emitting a VAD stop that would commit canceled audio. Normal End/Stop finalization still runs once.%cannot act as a SQL wildcard.Each failure was reproduced against the original implementation before applying the fix. Changes are split into four commits, with durable contracts updated in AGENTS.md.
Validation
All six Hybrid PR Checks passed for final head
109fa074744f4994344f3a7bd5a423a6ab2a36a2.The five Python skips concern optional locked QuickJS/FFmpeg and shipping-native-runtime qualification conditions. Provider regressions use local PCM and controlled upload callbacks; no live provider calls, physical microphone tests, installed-app smoke, installer build, or release were performed. The browser smoke ends at the durable queued-job boundary.
CI evidence