Mimic context#13
Open
zeehio wants to merge 2 commits into
Open
Conversation
It replaces the mimic_plugins, mimic_voice_list and mimic_lang_list global variables, so the mimic library can be used simultaneously and independently. Work is still needed to deal with other global variables
Codecov Report
@@ Coverage Diff @@
## development #13 +/- ##
===============================================
- Coverage 17.83% 17.08% -0.75%
===============================================
Files 80 80
Lines 8875 8936 +61
===============================================
- Hits 1583 1527 -56
- Misses 7292 7409 +117
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves some global variables (
mimic_voice_list,mimic_lang_list,mimic_plugins) into amimic_contextstructure. It is hard to know where global variables are being modified, so it is better to avoid them.It needs to be merged with other pull requests in other repositories, so don't merge it for now. 👍