Group Try-a-phrase chips by kind - #19
Open
MylesMCook wants to merge 1 commit into
Open
MylesMCook wants to merge 1 commit into
MylesMCook wants to merge 1 commit into
Conversation
The empty-state chips wrapped as one undifferentiated dump. Keep the same seven catalog phrases, but split them into labeled fieldsets so related examples sit together. Browse examples and button labels are unchanged. Co-authored-by: Myles Cook <MylesMCook@users.noreply.github.com>
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved review issues remain.
Pull request overview
Groups Try-a-phrase chips into labeled categories while preserving the existing phrase catalog.
Changes:
- Added grouped featured-example data.
- Rendered accessible labeled fieldsets.
- Added uniqueness validation for featured phrases.
File summaries
| File | Description |
|---|---|
src/shared/date-parser.test.ts |
Validates featured phrase uniqueness. |
src/features/parser/examples.ts |
Defines grouped example phrases. |
src/features/parser/components/date-picker.tsx |
Renders grouped phrase chips. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
The Try-a-phrase empty state listed seven chips in one wrapping row, so unrelated examples sat next to each other.
Same seven catalog phrases, now in three labeled fieldsets inside
role="group"/aria-label="Try a phrase":today plus 2 weeks minus 3 days,jan 31 2026 plus 1 month plus 1 month2 weeks after dec 25,friday next weekCall Sam tomorrow at noon,tomorrow from 2pm to 4pm,every Monday at noon for 5 occurrencesNo new parser language. Chip buttons still use the phrase as their accessible name. Browse examples still holds the full catalog.
How did you check it?
pnpm check— pass (0 errors; existing SDK import-closure warning)pnpm test -- src/shared/date-parser.test.ts— 107 passednode examples/app/verify-calculator.mjs—{ status: "passed", runs: 6 }at 320 and 1280America/Chicago, clock2026-09-12T16:00:00Z); 320pxscrollWidth <= innerWidthAnything that could break?
Empty-state layout grows a little vertically because of the group labels. Phone-width still wraps chips inside each fieldset.