Enable GitHub auto-deploy on main - #22
Merged
Merged
Conversation
Remove the opt-in skip so production deploys run on main unless CLOUDFLARE_DEPLOY_ENABLED is false. Deploy the compatibility Worker after tempus. Co-authored-by: Myles Cook <MylesMCook@users.noreply.github.com>
There was a problem hiding this comment.
🔵 Needs a closer look
Production deployment behavior and credentials require final human verification.
Pull request overview
Enables default-on Cloudflare deployment from main, including sequential deployment of both Workers, with updated documentation.
Changes:
- Adds repository, branch, fork, and opt-out safeguards.
- Validates credentials before deployment.
- Updates deployment and security guidance.
File summaries
| File | Summary |
|---|---|
docs/security-review.md |
Updates CI and production-deployment guidance. |
docs/cloudflare-workers.md |
Documents deployment behavior and recovery controls. |
.github/workflows/deploy-cloudflare.yml |
Adds guarded dual-Worker deployment and credential checks. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
GitHub auto-deploy was skipping every
mainpush because the job requiredCLOUDFLARE_DEPLOY_ENABLED=true. That opt-in is now off:mainin this repository deploys unless the variable is set tofalse.The workflow also deploys
tempus-totalaftertempus, and fails with a clear error if the Cloudflare secrets are missing. Forks still do not deploy.How did you check it?
.github/workflows/deploy-cloudflare.ymland confirmed the jobifis default-on, fork-safe, and includes both Wrangler deploys.CLOUDFLARE_API_TOKEN/CLOUDFLARE_ACCOUNT_IDsecrets are required for the job to succeed after merge.Anything that could break?
If the GitHub Cloudflare token is still the invalid one from 12 Sep, this job will run and fail instead of skipping. Pause with
CLOUDFLARE_DEPLOY_ENABLED=false. Pull requests still do not deploy.