Remove manual minLovelace calculation now that SDK returns correct value#40
Merged
Merged
Conversation
Co-authored-by: SynthLuvr <131367121+SynthLuvr@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Remove minLovelace calculation in mint.ts
Remove manual minLovelace calculation now that SDK returns correct value
Mar 2, 2026
SynthLuvr
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
calculateMinimumUtxoLovelacepreviously omitted the 160-byte UTxO entry overhead from its result, requiring a manual workaround. IntersectMBO/evolution-sdk#169 fixes this, making the workaround unnecessary.Changes
src/mint.ts: Remove the manual(cborSize + 160n) * coinsPerUtxoBytecalculation and pass the actualcoinsPerUtxoBytedirectly tocalculateMinimumUtxoLovelace, using its result asminLovelace.Before:
After:
The 1 ADA lovelace placeholder is retained to ensure consistent 5-byte CBOR encoding of the lovelace field.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.