Skip to content

Fix missing await on response.json() in sendViaKey error path#27

Merged
SynthLuvr merged 3 commits into
mainfrom
copilot/investigate-duplicate-transactions
Mar 10, 2026
Merged

Fix missing await on response.json() in sendViaKey error path#27
SynthLuvr merged 3 commits into
mainfrom
copilot/investigate-duplicate-transactions

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 10, 2026

sendViaKey passed an unresolved Promise to parseError instead of the awaited JSON body, causing every non-200 error response to surface as "Unknown {}" rather than the actual server message.

// before
if (response.status !== 200) return parseError(response.json());

// after
if (response.status !== 200) return parseError(await response.json());

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: SynthLuvr <131367121+SynthLuvr@users.noreply.github.com>
Copilot AI changed the title [WIP] Investigate duplicate transactions in nova command Fix duplicate transactions caused by missing await in sendViaKey error path Mar 10, 2026
Comment thread api.ts
Comment thread commands/transactions.ts Outdated
Comment thread commands/transactions.ts Outdated
Co-authored-by: SynthLuvr <131367121+SynthLuvr@users.noreply.github.com>
Copilot AI changed the title Fix duplicate transactions caused by missing await in sendViaKey error path Fix missing await on response.json() in sendViaKey error path Mar 10, 2026
@SynthLuvr SynthLuvr marked this pull request as ready for review March 10, 2026 15:16
@SynthLuvr SynthLuvr merged commit 0aa83ac into main Mar 10, 2026
1 check passed
@SynthLuvr SynthLuvr deleted the copilot/investigate-duplicate-transactions branch March 10, 2026 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants