fix: add time bounds to /orders endpoint to prevent timeouts#898
Merged
fix: add time bounds to /orders endpoint to prevent timeouts#898
Conversation
…pools The get_orders_status query scanned the entire order history for a pool with no time constraint, causing 504s on high-volume pools like SUI_USDC. Add start_time/end_time query params (defaulting to last 7 days) so callers control the scan window and no single query can blow up the DB. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
johnjmartin
approved these changes
Mar 14, 2026
emmazzz
approved these changes
Mar 14, 2026
| let end_time = params.end_time(); | ||
| let start_time = params | ||
| .start_time() | ||
| .unwrap_or_else(|| end_time - 7 * 24 * 60 * 60 * 1000); |
Collaborator
There was a problem hiding this comment.
nit: do we want to make this default time range configurable?
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/ordersendpoint timed out (504) on busy pools like SUI_USDC becauseget_orders_statusscanned the entire order event history with no time constraintstart_timeandend_timequery params to both CTEs (latest_eventsandplaced_events), reusing the existingParameterUtiltraitstart_timeis omitted,nowifend_timeis omitted — callers can widen the window as neededTest plan
/orderson SUI_USDC pool — confirm it returns within 1-2sstart_time/end_timeparams correctly narrow resultsstatusandlimitfilters still work as before🤖 Generated with Claude Code