[Guardian] [2/3] Support multiple KP certs per share#791
Open
mskd12 wants to merge 1 commit into
Open
Conversation
|
mskd12
changed the title
mskd12
marked this pull request as ready for review
July 15, 2026 23:17
mskd12
changed the title
Collaborator
Style Guide AuditAll 1 file(s) pass the style guide audit. |
mskd12
changed the title
dlukegordon
reviewed
Jul 17, 2026
| pub sharing_seq: u64, | ||
| pub cert_seq: u64, | ||
| pub encrypted_shares: KPEncryptedShares, | ||
| pub encrypted_shares: KPEncryptedSharesRoster, |
Contributor
There was a problem hiding this comment.
This changes the persisted kp-shares v1 format, so existing signed recovery records will no longer deserialize. Can we introduce a v2 log schema and retain v1 decoding? Otherwise upgraded guardians cannot recover the existing BTC key.
dlukegordon
reviewed
Jul 17, 2026
mskd12
changed the title
mskd12
changed the base branch from
main
to
deepakmaram/remove-shares-from-guardian-info
July 17, 2026 23:40
Base automatically changed from
deepakmaram/remove-shares-from-guardian-info
to
main
July 18, 2026 00:10
mskd12
force-pushed
the
deepakmaram/iop-487-kp-cert-groups
branch
from
July 18, 2026 00:27
bcd3101 to
54d25a0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #840.
Summary
This PR lets each KP roster entry contain more than one PGP certificate. The roster order still assigns one share to each KP.
The guardian encrypts that share separately for every certificate in the entry and stores each ciphertext by fingerprint. It rejects duplicate fingerprints and verifies that each ciphertext is encrypted to the matching certificate.
The KP ceremony uses
kp_pgp_cert_pathto find the KP roster entry, then decrypts every copy and checks the share commitment. Provisioning decrypts and signs with only the selected certificate.Validation
make fmt