Skip to content

Add per-request deadlines to sui-rpc unary calls#810

Open
zhouwfang wants to merge 1 commit into
mainfrom
zhoufang/iop-446-add-per-request-deadlines-to-sui-rpc-unary-calls
Open

Add per-request deadlines to sui-rpc unary calls#810
zhouwfang wants to merge 1 commit into
mainfrom
zhoufang/iop-446-add-per-request-deadlines-to-sui-rpc-unary-calls

Conversation

@zhouwfang

Copy link
Copy Markdown
Contributor

#16

@zhouwfang zhouwfang requested a review from bmwill as a code owner July 13, 2026 22:41

@bmwill bmwill left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grpc already has a built in way to express this. Just include the timeout in the tonic::Request

@zhouwfang

Copy link
Copy Markdown
Contributor Author

Grpc already has a built in way to express this. Just include the timeout in the tonic::Request

Client-side they're the same mechanism. tonic enforces Request::set_timeout by racing the response future, just like this layer. Channel-level for two reasons: set_timeout is opt-in per call (16 sites), so one forgotten site reintroduces the hang; and it puts grpc-timeout on the wire, where whether the subscription survives depends on the server/proxy (tonic only bounds the accept; envoy/grpc-go cancel the stream). Can inject grpc-timeout centrally instead (exempting the
subscription) if you prefer the built-in protocol.

@zhouwfang zhouwfang requested a review from bmwill July 13, 2026 23:00
@bmwill

bmwill commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

reintroduces the hang

can you elaborate more on what hang you're referring to?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants