Add per-request deadlines to sui-rpc unary calls#810
Conversation
bmwill
left a comment
There was a problem hiding this comment.
Grpc already has a built in way to express this. Just include the timeout in the tonic::Request
Client-side they're the same mechanism. tonic enforces Request::set_timeout by racing the response future, just like this layer. Channel-level for two reasons: set_timeout is opt-in per call (16 sites), so one forgotten site reintroduces the hang; and it puts grpc-timeout on the wire, where whether the subscription survives depends on the server/proxy (tonic only bounds the accept; envoy/grpc-go cancel the stream). Can inject grpc-timeout centrally instead (exempting the |
can you elaborate more on what hang you're referring to? |
#16