Add discovery address prober for trusted-peer reachability metrics - #27124
Merged
Merged
Conversation
aschran
temporarily deployed
to
sui-typescript-aws-kms-test-env
July 1, 2026 20:12 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
aschran
marked this pull request as ready for review
July 1, 2026 20:19
aschran
temporarily deployed
to
sui-typescript-aws-kms-test-env
July 1, 2026 20:19 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
mystenmark
reviewed
Jul 14, 2026
| }; | ||
|
|
||
| if let Some(prober_config) = &config.address_prober { | ||
| prober_config.validate()?; |
Contributor
There was a problem hiding this comment.
should validation failure exit this entire function?
Contributor
Author
There was a problem hiding this comment.
yes it was intentional to crash the process if it's started with an invalid config, but will move this somewhere more sensible
mystenmark
approved these changes
Jul 14, 2026
aschran
temporarily deployed
to
sui-typescript-aws-kms-test-env
July 14, 2026 19:56 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
aschran
enabled auto-merge (squash)
July 14, 2026 19:56
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Validators have no signal today when a peer advertises an unreachable address (e.g. a wrong external address gossiped via discovery), which silently degrades connectivity. This adds a prober that runs on validators and periodically checks whether each trusted peer's advertised P2P and consensus addresses are actually reachable, exposing the results as Prometheus metrics plus an admin endpoint that dumps full per-address detail for operators to act on.
Bumps
anemoto MystenLabs/anemo#75 for the non-disruptiveNetwork::probe_addressthe P2P check uses.Test plan
New
discovery_testssim tests cover the core differential (a validator's real address probes reachable, its bad gossiped address does not), plus no-false-positives and reconfiguration cleanup cases.Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.