Fixed crash for 00003.LANG / #2 + table macros#5
Open
octopoulos wants to merge 1 commit intoMystixor:masterfrom
Open
Fixed crash for 00003.LANG / #2 + table macros#5octopoulos wants to merge 1 commit intoMystixor:masterfrom
octopoulos wants to merge 1 commit intoMystixor:masterfrom
Conversation
Owner
|
Thank you very much for your PR. I was not yet aware of this problem with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why does it crash? Because ImGui::Text(something) was used and the something contained %s, without argument.
ImGui::Text always formats (like printf) => replaced with ImGui::TextUnformatted
Basically I was just going to fix the crash then thought I might as well do #2.
Now I see some other things that could be done.