Add detections-vehicles dataset to backend#83
Conversation
|
Thanks @leothomas
Running this with 1.8.0 of the dashboard, I noticed a couple of issues. Unsure whether they should be solved on the API, or frontend, but raising them here:
|
Needed to support NASA-IMPACT/covid-api#83
|
Tested this locally and the data seems to show up correctly. I did notice the domain error reported by @olafveerman, and this is a problem with the frontend. We were considering domains with 2 dates to be a range according to the time unit. This has been the case and worked until this moment. The very useful Long story short, here's the PR with the fix: NASA-IMPACT/covid-dashboard#455 |
…date background location in metadata file
…ASA-IMPACT/covid-api into feature/add-detections-vehicle-dataset
|
Fixed the issue with @olafveerman re: observations colour - I'm not seeing anywhere on the backend to specify the colours of the observations. If that's not fixable through the front end, I'm happy to update the |
|
This looks good! Holding off on merging for a couple of days, until the Story feature has been launched and stable. |
|
@olafveerman This PR has been open for a while. Can we merge, now that the Story feature has been launched? |
What I did:
Added
detections-vehiclesdataset - addresses covid-dashboard issue #440How I did it:
Extracted scene_ids for each feature in the two geojsons currently in S3 and built + uploaded a
detections_scenes.csvfile.Created a new dataset metadata file called
detections-vehicles.jsonwhich is very similar todetection-plane.jsonanddetections-ship.json.Added
detections-vehicleto all datasets which hasdetections-shipanddetection-planeas exclusive datasetsHow you can test it:
Run
docker-compose up --buildhttp://localhost:8000/v1/datasetsnotice a new dataset fordetections-vehiclesis present (with{spotlightId}in url, since no spotlight has been specified)http://localhost:8000/v1/datasets/lanotice that thedetections-vehiclesis still presenthttp://localhost:8000/v1/datasets/nynotices that thedetections-vehiclesis no longer present@olafveerman @drewbo would love some feedback on the
detections-vehicles.jsonmetadata files (I copy-pasted the description fromdetections-ships.json, not sure if theinfofield is missing anything)@danielfdsilva tagging you because the format of the geojsons in s3 seems different from the other
detection-*datasets. Let me know if you need anything in order to implement in the front end@lillythomas fyi