Repository navigation
Fix Phoebe Colors (and other minor things) - #81
Merged
Merged
Conversation
scastro-nasa
approved these changes
Oct 8, 2026
scastro-nasa
left a comment
scastro-nasa
left a comment
Contributor
There was a problem hiding this comment.
gahhhh curse the cached assets (but actually they're very handy) -- thanks for fixing this 🙏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes colors for PB. I think that this commit changed the material names to be
phoebe_<color_name>instead ofclearpath_<color_name>, but I don't think the correspondingphoebe_<color_name>s were added. This didn't end up showing up in final results because we re-use assets folders, which already had that stuff baked in. Now looking at separating visual/collision tags, I found that this was an issue, and all of the ridgeback components showed up gray.So this adds those colors in, as well as some small stuff I decided to throw in: