Read Kerchunk and file-like object datasets#938
Conversation
davidhassell
added
enhancement
|
Hang on - overlooked something (to do with PP/UM datasets) - so converting to draft for now while I make some additions. |
sadielbartholomew
left a comment
sadielbartholomew
left a comment
There was a problem hiding this comment.
A few dependency related tweaks are needed but otherwise all good and ready to go, I say. Please let me know what you think.
| @@ -1,4 +1,4 @@ | |||
| netCDF4==1.7.2 | |||
| netCDF4>=1.7.2 | |||
There was a problem hiding this comment.
As discussed offline, we pinned to 1.7.2 only due to #899 so allowing a minimum pin might be unsafe and cause users to hit that issue on install - and the latest version 1.7.4 exhibits different issues.
Best leave as-is for now and we can see review on the next release in a few months time.
There was a problem hiding this comment.
discussed offline (again!) and have decided to leave as netCDF4>=1.7.2 for now :)
Co-authored-by: Sadie L. Bartholomew <sadie.bartholomew@ncas.ac.uk>
sadielbartholomew
left a comment
sadielbartholomew
left a comment
There was a problem hiding this comment.
Thanks for updating. Please merge!
2 participants
Fixes #936 (kerchunk) and #937 (file-like object).
Needs NCAS-CMS/cfdm#402 to be resolved, first.