FPM-904 - Modifications to flatline QC check#60
Merged
Conversation
Contributor
simonstanley
left a comment
simonstanley
left a comment
There was a problem hiding this comment.
All looks good. Did you want to add tests in there for string data?
Collaborator
Author
Sure |
simonstanley
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FlatLineCheckthresholdtomin_count- thought it is a bit more understandable what the variable is fortoleranceparameters - this let's users give a buffer around the values that it's checking for repeats fromignore_value- values are now cast to the column dtype before comparison, with a clearTypeErrorif incompatible. Example of [0, 3.1] should now work as the integer "0" can be cast safely to float.Docs
ignore_valueandthreshold