Merged
Conversation
Merged
lcdurkan
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Previously, registering a flag system required supplying explicit power-of-2 integers for each category, e.g:
tf.register_flag_system("qc", {"OUT_OF_RANGE": 1, "SPIKE": 2, "LOW_BATTERY": 4})This PR allows a list of strings to be passed instead, with bit values assigned automatically:
tf.register_flag_system("qc", ["OUT_OF_RANGE", "SPIKE", "LOW_BATTERY"])The list is sorted before values are assigned, ensuring the same set of names always produces the same mapping regardless of input order. Passing None (now the default) or an empty list produces a minimal flag system with a single FLAGGED member at value 1.
Main changes
Note