Merged
Conversation
simsta87
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Previously, the QC and infill methods didn't integrate directly with the flagging systems. This PR integrates the flag system into qc_check() and infill() so users can automatically flag rows based on QC failures or infill application.
Main changes
intoparameter; replaces withflag_params. Without flag_params, returns a boolean Series (as before whenintowas False). Whenflag_paramsare provided, sets the given flag value to the given flag column on all rows that failed the QC check, returns a new TimeFrameflag_params. When provided, sets the given flag value to the given flag column on rows that were null before infilling and non-null after.Notes
Documentation will get wrapped up in FPM-283.