Repository navigation
Correct test assertion for PCT_NAT_PFT dimension order - #44
Merged
Merged
Conversation
The test was asserting that 'topounit' must precede 'natpft' in dimension order, but this contradicts the SURFACE_VAR_SPECS and the intentional design decision from commit 641aa7e (2026-07-20). Background: - The test was written on 2026-07-16 (commit da03322) expecting topounit-first - Four days later on 2026-07-20 (commit 641aa7e), specs were deliberately changed to put class dimensions (natpft, cft, nglcec, etc.) BEFORE topounit for consistency across all topounit-indexed variables - The test was never updated to reflect this change The spec explicitly defines PCT_NAT_PFT dims as "natpft,topounit,lsmlat,lsmlon", and the implementation correctly follows this order. The test assertion was wrong. Changes: - Fix test to assert natpft precedes topounit (not vice versa) - Update misleading comment in sfile.py to clarify class dims come first - Add reference to commit 641aa7e in test comment for future clarity Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test was asserting that 'topounit' must precede 'natpft' in dimension order, but this contradicts the SURFACE_VAR_SPECS and the intentional design decision from commit 641aa7e (2026-07-20).
Background:
The spec explicitly defines PCT_NAT_PFT dims as "natpft,topounit,lsmlat,lsmlon", and the implementation correctly follows this order. The test assertion was wrong.
Changes: