Repository navigation
Preserve model coordinates across ERA5 sampling backends - #47
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Domain.cellsgeometry, longitude, latitude, zone, and weights when attaching ERA5 sampling provenancesampling_reference_lonandsampling_reference_latWhy
GEE replaces polygons containing no ERA5 pixel centers with a centroid for sampling. That sampling-only fallback was being copied back into the Domain model coordinates, while ARCO retained the original polygon's representative point. For TL27 this moved
zone_mappings.txtby about 79 m and made newly generated met files inconsistent with established domain and surface files.The GEE fallback remains available for data extraction, but it can no longer overwrite the coordinate used by
zone_mappings.txt,LONGXY/LATIXY, domain files, or surface files.Verification
zone_mappings.txtfor the same Domain46 passed, 1 skipped