Missing gages layer in some geopackages#101
Open
danielcumpton wants to merge 1 commit into
Open
Conversation
…ssed into the polars is_in function
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Short description explaining the high-level reason for the pull request]
Additions
The flowpath IDs returned from the graph are int64 and the fp_id column in the gages layer are float64. When the int64s are passed into the polars is_in function to filter the gages layer for flowpaths in the subset, there are some times when a flowpath ID isn't return by is_in when it should. This is likely due to small machine precision level difference in the float64 where it won't equal the int64. This is only happening when running inside a container. This PR casts the float64 fp_id column in gages to int64 to match the fp_ids being looked up.
Removals
Changes
Testing
Screenshots
Notes
Todos
Checklist
Testing checklist
Target Environment support
Accessibility
Other