Skip to content

Missing gages layer in some geopackages#101

Open
danielcumpton wants to merge 1 commit into
mainfrom
NGWPC-11144_missing_gages_layer
Open

Missing gages layer in some geopackages#101
danielcumpton wants to merge 1 commit into
mainfrom
NGWPC-11144_missing_gages_layer

Conversation

@danielcumpton

Copy link
Copy Markdown

[Short description explaining the high-level reason for the pull request]

Additions

The flowpath IDs returned from the graph are int64 and the fp_id column in the gages layer are float64. When the int64s are passed into the polars is_in function to filter the gages layer for flowpaths in the subset, there are some times when a flowpath ID isn't return by is_in when it should. This is likely due to small machine precision level difference in the float64 where it won't equal the int64. This is only happening when running inside a container. This PR casts the float64 fp_id column in gages to int64 to match the fp_ids being looked up.

Removals

Changes

Testing

Screenshots

Notes

Todos

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Visually tested in supported browsers and devices (see checklist below 👇)
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

Testing checklist

Target Environment support

  • Windows
  • Linux
  • Browser

Accessibility

  • Keyboard friendly
  • Screen reader friendly

Other

  • Is useable without CSS
  • Is useable without JS
  • Flexible from small to large screens
  • No linting errors or warnings
  • JavaScript tests are passing

@danielcumpton danielcumpton self-assigned this Jul 17, 2026
@danielcumpton
danielcumpton requested a review from dylanlee July 20, 2026 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant