NRL-721 Fix sonarqube complexity warning

Author: sandyforresternhs

scripts/seed_sandbox_table.py

@@ -230,6 +230,38 @@ def _create_pointer_item(
         return None, None
 
 
+def _generate_pointers_for_custodian(
+    template: dict,
+    pointer_type: str,
+    custodian: str,
+    pointers_per_type: int,
+    counter_start: int,
+    testnum_iter,
+) -> tuple[list[dict], list[list[str]], int]:
+    batch_items = []
+    csv_rows = []
+    counter = counter_start
+
+    for _ in range(pointers_per_type):
+        counter += 1
+
+        try:
+            nhs_number = next(testnum_iter)
+        except StopIteration:
+            print(f"\n✗ Error: Ran out of NHS numbers at pointer {counter}")
+            break
+
+        put_req, csv_data = _create_pointer_item(
+            template, custodian, nhs_number, counter, pointer_type
+        )
+
+        if put_req and csv_data:
+            batch_items.append(put_req)
+            csv_rows.append(csv_data)
+
+    return batch_items, csv_rows, counter
+
+
 def _generate_and_write_pointers(
     table_name: str, templates: dict[str, dict], pointers_per_type: int, testnum_iter
 ) -> tuple[list[list[str]], int]:
@@ -240,26 +272,21 @@ def _generate_and_write_pointers(
 
     for pointer_type, template in templates.items():
         for custodian in CUSTODIANS:
-            for _ in range(pointers_per_type):
-                counter += 1
-
-                try:
-                    nhs_number = next(testnum_iter)
-                except StopIteration:
-                    print(f"\n✗ Error: Ran out of NHS numbers at pointer {counter}")
-                    break
-
-                put_req, csv_data = _create_pointer_item(
-                    template, custodian, nhs_number, counter, pointer_type
-                )
-
-                if put_req and csv_data:
-                    batch_upsert_items.append(put_req)
-                    pointer_data.append(csv_data)
-
-                    if len(batch_upsert_items) >= 25:
-                        _write_batch_to_dynamodb(table_name, batch_upsert_items)
-                        batch_upsert_items = []
+            batch_items, csv_rows, counter = _generate_pointers_for_custodian(
+                template,
+                pointer_type,
+                custodian,
+                pointers_per_type,
+                counter,
+                testnum_iter,
+            )
+
+            batch_upsert_items.extend(batch_items)
+            pointer_data.extend(csv_rows)
+
+            if len(batch_upsert_items) >= 25:
+                _write_batch_to_dynamodb(table_name, batch_upsert_items)
+                batch_upsert_items = []
 
     _write_batch_to_dynamodb(table_name, batch_upsert_items)