Skip to content

NRL-1948 use new permission model#1153

Merged
anjalitrace2-nhs merged 16 commits intodevelopfrom
NRL-1948-use-new-permission-model
Mar 3, 2026
Merged

NRL-1948 use new permission model#1153
anjalitrace2-nhs merged 16 commits intodevelopfrom
NRL-1948-use-new-permission-model

Conversation

@anjalitrace2-nhs
Copy link
Contributor

@anjalitrace2-nhs anjalitrace2-nhs commented Feb 25, 2026

When a request:

  • is missing the nhsd-connection-metadata OR nhsd-client-rp-details headers
  • specifies the ODS code in the NHSD-End-User-Organisation-ODS header AND the app id in the nhsd-nrl-app-id header

NRL will attempt to lookup pointer permissions using the new permissions model - <producer|consumer>/<app id>/<ods>.json in S3

There are no permissions set up here yet and it wouldn't yet do anything with our new shiny ones anyways!

This is deployed on my feature branch https://anjal-dev.api.record-locator.dev.national.nhs.uk if you'd like to have a play 🛝

No environment defaults or app-level permissions in scope yet

TODO

  • switch permissions lookup to lambda layer rather than s3
  • rename "new perms" -> "v2 perms"
  • manually test with postman
  • make unit testing better - will follow up in another PR

@sonarqubecloud
Copy link

@github-actions
Copy link

🚀 PR environment successfully deployed.
Commit Hash: e7c8761aee20a368d7c89202d3763c4e4598a46d
URL: https://nrl1948-01ba47.api.record-locator.dev.national.nhs.uk/

@github-actions
Copy link

🚀 PR environment successfully deployed.
Commit Hash: 1c876ed765d9a8180698147ab89f2d9d2c625c3d
URL: https://nrl1948-01ba47.api.record-locator.dev.national.nhs.uk/

…ssions in lambda layer rather than s3 (as we agreed)
@github-actions
Copy link

🚀 PR environment successfully deployed.
Commit Hash: b00e987c8ff907cdc3a7ec809bf0ee22ff485e50
URL: https://nrl1948-01ba47.api.record-locator.dev.national.nhs.uk/

@github-actions
Copy link

github-actions bot commented Mar 2, 2026

🚀 PR environment successfully deployed.
Commit Hash: 33daa4857b271e3f954ff28913cdb629f7e55ee9
URL: https://nrl1948-01ba47.api.record-locator.dev.national.nhs.uk/

@github-actions
Copy link

github-actions bot commented Mar 2, 2026

🚀 PR environment successfully deployed.
Commit Hash: 4e1414b1cba6bb25a1eac59891133b4628e40b17
URL: https://nrl1948-01ba47.api.record-locator.dev.national.nhs.uk/

@github-actions
Copy link

github-actions bot commented Mar 2, 2026

🚀 PR environment successfully deployed.
Commit Hash: 1e3af17f032cc09429a726653cf05e5982f466d0
URL: https://nrl1948-01ba47.api.record-locator.dev.national.nhs.uk/

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 2, 2026

@github-actions
Copy link

github-actions bot commented Mar 2, 2026

🚀 PR environment successfully deployed.
Commit Hash: 15d1d51bc477a0f4fb327de143433f6100e19b04
URL: https://nrl1948-01ba47.api.record-locator.dev.national.nhs.uk/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants