Skip to content

[NRL-1990] Allow unstructured data for text/html contents in pointers #1162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mattdean3-nhs wants to merge 2 commits into
base: hotfix/v3.0.36
Choose a base branch
from

[NRL-1990] Temporarily skip test that checks unstructured is not allo…

9cc447a
Select commit
Loading
Failed to load commit list.
Open

[NRL-1990] Allow unstructured data for text/html contents in pointers #1162

[NRL-1990] Temporarily skip test that checks unstructured is not allo…
9cc447a
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Mar 5, 2026 in 53s

Quality Gate failed

Failed conditions
49.3% Coverage on New Code (required ≥ 80%)
C Reliability Rating on New Code (required ≥ A)
C Security Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Annotations

Check warning on line 723 in layer/nrlf/core/validators.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this redundant return. 

See more on https://sonarcloud.io/project/issues?id=NHSDigital_NRLF&issues=AZy9BQR9C2mJGV9gcnrF&open=AZy9BQR9C2mJGV9gcnrF&pullRequest=1162

Check warning on line 25 in .github/workflows/update-lambda-permissions.yml

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Move this write permission from workflow level to job level. 

See more on https://sonarcloud.io/project/issues?id=NHSDigital_NRLF&issues=AZy9BQShC2mJGV9gcnrI&open=AZy9BQShC2mJGV9gcnrI&pullRequest=1162

Check warning on line 18 in .github/workflows/pr-env-destroy.yml

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Move this write permission from workflow level to job level. 

See more on https://sonarcloud.io/project/issues?id=NHSDigital_NRLF&issues=AZy9BQTMC2mJGV9gcnrR&open=AZy9BQTMC2mJGV9gcnrR&pullRequest=1162

Check warning on line 15 in .github/workflows/pr-env-deploy.yml

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Move this write permission from workflow level to job level. 

See more on https://sonarcloud.io/project/issues?id=NHSDigital_NRLF&issues=AZy9BQTqC2mJGV9gcnrU&open=AZy9BQTqC2mJGV9gcnrU&pullRequest=1162

Check warning on line 36 in layer/nrlf/core/dynamodb/repository.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use the "type" parameter syntax to declare this generic class. 

See more on https://sonarcloud.io/project/issues?id=NHSDigital_NRLF&issues=AZy9BQQ5C2mJGV9gcnq5&open=AZy9BQQ5C2mJGV9gcnq5&pullRequest=1162

Check warning on line 144 in terraform/account-wide-infrastructure/modules/athena/sql/rep_producer.sql

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this commented out code. 

See more on https://sonarcloud.io/project/issues?id=NHSDigital_NRLF&issues=AZy9BQO_C2mJGV9gcnqy&open=AZy9BQO_C2mJGV9gcnqy&pullRequest=1162

Check warning on line 19 in .github/workflows/deploy-account-wide-infra.yml

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Move this write permission from workflow level to job level. 

See more on https://sonarcloud.io/project/issues?id=NHSDigital_NRLF&issues=AZy9BQS8C2mJGV9gcnrM&open=AZy9BQS8C2mJGV9gcnrM&pullRequest=1162

Check warning on line 661 in layer/nrlf/core/validators.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename method "_validate_practiceSetting" to match the regular expression ^[a-z_][a-z0-9_]*$. 

See more on https://sonarcloud.io/project/issues?id=NHSDigital_NRLF&issues=AZy9BQR9C2mJGV9gcnrE&open=AZy9BQR9C2mJGV9gcnrE&pullRequest=1162

Check warning on line 17 in .github/workflows/deploy-account-wide-infra.yml

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Move this write permission from workflow level to job level. 

See more on https://sonarcloud.io/project/issues?id=NHSDigital_NRLF&issues=AZy9BQS8C2mJGV9gcnrL&open=AZy9BQS8C2mJGV9gcnrL&pullRequest=1162

Check warning on line 409 in layer/nrlf/core/validators.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add replacement fields or use a normal string instead of an f-string. 

See more on https://sonarcloud.io/project/issues?id=NHSDigital_NRLF&issues=AZy9BQR9C2mJGV9gcnrC&open=AZy9BQR9C2mJGV9gcnrC&pullRequest=1162

Check warning on line 16 in .github/workflows/pr-env-deploy.yml

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Move this write permission from workflow level to job level. 

See more on https://sonarcloud.io/project/issues?id=NHSDigital_NRLF&issues=AZy9BQTqC2mJGV9gcnrV&open=AZy9BQTqC2mJGV9gcnrV&pullRequest=1162

Check warning on line 16 in .github/workflows/pr-env-destroy.yml

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Move this write permission from workflow level to job level. 

See more on https://sonarcloud.io/project/issues?id=NHSDigital_NRLF&issues=AZy9BQTMC2mJGV9gcnrP&open=AZy9BQTMC2mJGV9gcnrP&pullRequest=1162

Check warning on line 71 in api/producer/searchDocumentReference/search_document_reference.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this "TODO" comment. 

See more on https://sonarcloud.io/project/issues?id=NHSDigital_NRLF&issues=AZy9BQQDC2mJGV9gcnq3&open=AZy9BQQDC2mJGV9gcnq3&pullRequest=1162

Check warning on line 27 in .github/workflows/update-lambda-permissions.yml

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Move this write permission from workflow level to job level. 

See more on https://sonarcloud.io/project/issues?id=NHSDigital_NRLF&issues=AZy9BQShC2mJGV9gcnrJ&open=AZy9BQShC2mJGV9gcnrJ&pullRequest=1162

Check warning on line 303 in layer/nrlf/core/validators.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unpack this comprehension expression 

See more on https://sonarcloud.io/project/issues?id=NHSDigital_NRLF&issues=AZy9BQR9C2mJGV9gcnrA&open=AZy9BQR9C2mJGV9gcnrA&pullRequest=1162

Check warning on line 341 in layer/nrlf/core/validators.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this redundant return. 

See more on https://sonarcloud.io/project/issues?id=NHSDigital_NRLF&issues=AZy9BQR9C2mJGV9gcnq_&open=AZy9BQR9C2mJGV9gcnq_&pullRequest=1162

Check warning on line 659 in layer/nrlf/core/validators.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this redundant return. 

See more on https://sonarcloud.io/project/issues?id=NHSDigital_NRLF&issues=AZy9BQR9C2mJGV9gcnrD&open=AZy9BQR9C2mJGV9gcnrD&pullRequest=1162

Check warning on line 153 in terraform/account-wide-infrastructure/modules/athena/sql/rep_producer.sql

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this commented out code. 

See more on https://sonarcloud.io/project/issues?id=NHSDigital_NRLF&issues=AZy9BQO_C2mJGV9gcnqz&open=AZy9BQO_C2mJGV9gcnqz&pullRequest=1162

Check warning on line 233 in layer/nrlf/core/dynamodb/model.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Group parts of the regex together to make the intended operator precedence explicit. 

See more on https://sonarcloud.io/project/issues?id=NHSDigital_NRLF&issues=AZy9BQRNC2mJGV9gcnq7&open=AZy9BQRNC2mJGV9gcnq7&pullRequest=1162

Check warning on line 14 in .github/workflows/pr-env-deploy.yml

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Move this read permission from workflow level to job level. 

See more on https://sonarcloud.io/project/issues?id=NHSDigital_NRLF&issues=AZy9BQTqC2mJGV9gcnrS&open=AZy9BQTqC2mJGV9gcnrS&pullRequest=1162

Check warning on line 398 in layer/nrlf/core/validators.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add replacement fields or use a normal string instead of an f-string. 

See more on https://sonarcloud.io/project/issues?id=NHSDigital_NRLF&issues=AZy9BQR9C2mJGV9gcnrB&open=AZy9BQR9C2mJGV9gcnrB&pullRequest=1162

Check warning on line 18 in .github/workflows/deploy-account-wide-infra.yml

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Move this read permission from workflow level to job level. 

See more on https://sonarcloud.io/project/issues?id=NHSDigital_NRLF&issues=AZy9BQS8C2mJGV9gcnrK&open=AZy9BQS8C2mJGV9gcnrK&pullRequest=1162

Check warning on line 25 in terraform/account-wide-infrastructure/modules/glue/LogSchemaGeneration/LogSchemaGeneration.ipynb

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

AWS region should not be set with a hardcoded String 

See more on https://sonarcloud.io/project/issues?id=NHSDigital_NRLF&issues=AZy9BQOOC2mJGV9gcnqx&open=AZy9BQOOC2mJGV9gcnqx&pullRequest=1162

Check warning on line 15 in .github/workflows/pr-env-destroy.yml

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Move this read permission from workflow level to job level. 

See more on https://sonarcloud.io/project/issues?id=NHSDigital_NRLF&issues=AZy9BQTMC2mJGV9gcnrN&open=AZy9BQTMC2mJGV9gcnrN&pullRequest=1162

Check warning on line 202 in layer/nrlf/core/dynamodb/model.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove duplicates in this character class. 

See more on https://sonarcloud.io/project/issues?id=NHSDigital_NRLF&issues=AZy9BQRNC2mJGV9gcnq6&open=AZy9BQRNC2mJGV9gcnq6&pullRequest=1162
View more details on SonarQubeCloud