Fix TypeScript compiler issues#280
Merged
paulrobertlloyd merged 4 commits intoMay 12, 2026
Merged
Conversation
Collaborator
|
@colinrotherham You might want to rebase this with |
colinrotherham
force-pushed
the
use-nhsuk-prototype-kit-package-typescript
branch
from
c76d103 to
07b97f1
Compare
Collaborator
Author
|
Just getting this one now @paulrobertlloyd Doesn't appear to be app/controllers/session.js:589:33 - error TS2339: Property 'code' does not exist on type 'Team'.
589 team = Team.findOne(team?.code || '001', data)
~~~~ |
colinrotherham
changed the title
paulrobertlloyd
force-pushed
the
use-nhsuk-prototype-kit-package-typescript
branch
from
07b97f1 to
92f97b7
Compare
paulrobertlloyd
force-pushed
the
use-nhsuk-prototype-kit-package-typescript
branch
from
92f97b7 to
4faba42
Compare
paulrobertlloyd
force-pushed
the
use-nhsuk-prototype-kit-package-typescript
branch
from
4faba42 to
705992e
Compare
Collaborator
Ooops, that should now be |
Collaborator
|
Thanks @colinrotherham ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Slowly getting rid of red squiggles