Clinics unmatched appointments#282
Merged
Merged
Conversation
For sessions: - left largely as is For consent: - no longer requesting consent for clinics - no longer creating consent replies for clinics For screening and recording: - no longer screening or recording for clinic sessions (may revisit this) For clinic invites - now inviting all clinic-ready children to clinic for all programmes for which they're ready (WILL revisit this) For clinic bookings and appointments: - reworked to be based on children's needs rather than a random selection of children and a random selection of clinics - actually finding a free slot and allocating it (in theory, not yet fully tested and looks a bit broken) - made unmatched details a near-miss - simplified to a single child per booking for now (WILL revisit this) - ensured that clinics aren't filled up
New: - added unmatched appointment count to total for Review tab - fix display of the name and relationship of parent for unmatched appointments
New: - now only inviting half of the schools to clinic (plus home-ed and unknown) - removed unnecessary filters for consent replies and recording (only school sessions will have patient-session records at that point)
We decided not to use registration for clinic sessions, so there's no need for attending or attended statuses. At least, none yet stated in user research, so let's simplify till we hear the need. This commit also checks for clinic booked status by looking for evidence of appointments in yet-to-happen clinics instead of the old way of looking at the last patient-session and hoping it was a clinic.
This commit also removes the session preset from clinic bookings and the primary programme from bookings and appointments; it's not needed there.
These came in after rebasing on main.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main changes herein:
While the work here is incomplete, I don't want the branch hanging around unmerged for too long, as it contains lots of changes to create-data that are important for other areas of work that I'm moving onto. I'll come back to the matching of unmatched appointments after we've done some more parent research.