Refactor parents as contacts#291
Merged
Merged
Conversation
paulrobertlloyd
force-pushed
the
refactor-parents
branch
from
62a95f4 to
6b8e806
Compare
paulrobertlloyd
force-pushed
the
refactor-parents
branch
from
6b8e806 to
9dd0055
Compare
paulrobertlloyd
force-pushed
the
refactor-parents
branch
from
9dd0055 to
6d4ef62
Compare
malross
reviewed
May 14, 2026
malross
reviewed
May 14, 2026
malross
requested changes
May 14, 2026
Collaborator
malross
left a comment
malross
left a comment
There was a problem hiding this comment.
Only one request for change and even then, it's just in a comment. As someone new to the codebase, it's the kind of comment that I would've valued more of.
paulrobertlloyd
force-pushed
the
refactor-parents
branch
from
6d4ef62 to
bb5b540
Compare
malross
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contact (formerly parent) details are now storied in global context, meaning editing a contact in one location will update it in another. This means contacts behave more like they do in production, and will be useful as we think about how contacts should look and behave going forward.
It also means contacts are structured in much the same way as other entities in the prototype.